Closed
Bug 1857752
Opened 2 years ago
Closed 2 years ago
crashreporter_gtk_common.cpp: do not use 'else' after 'return'
Categories
(Toolkit :: Crash Reporting, task)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
120 Branch
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: kusaalpokharel, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file, 1 obsolete file)
Filling as a good first bug to learn workflows.
do not use 'else' after 'return':
https://searchfox.org/mozilla-central/source/toolkit/crashreporter/client/crashreporter_gtk_common.cpp#81-85
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Reporter | |
Updated•2 years ago
|
Mentor: sledru
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → kusaalpokharel
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D191035
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e05893e2a723
Remove else block after return in if block. r=sylvestre Ledru
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox120:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
|
|
||
Updated•2 years ago
|
Attachment #9358554 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•